chrome/browser/chromeos/login/supervised/supervised_user_test_base.h - Issue 409743003: Use content::RunBlockingPoolTask() in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_test_base.h

Issue 409743003: Use content::RunBlockingPoolTask() in tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased + reverted changes to content/browser/media/webrtc_identity_store_unittest.cc. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_test_base.h

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h b/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h

index 78df6886a908cf107595d981533e5330502d5a15..97b96bf1118e9525a4d288c67d2e8feb3b07aa08 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_test_base.h

@@ -92,7 +92,7 @@ class SupervisedUserTestBase : public chromeos::LoginManagerTest {

int user_index,

const std::string& expected_display_name);

void SigninAsManager(int user_index);

- void RemoveSupervisedUser(unsigned long original_user_count,

+ void RemoveSupervisedUser(uint32 original_user_count,

sky 2014/09/08 15:51:37 Why this change? And if you're going to change thi

Lei Zhang 2014/09/08 18:21:01 re: uint32 vs uint32_t: https://code.google.com/p/

mtomasz 2014/09/09 01:15:31 I did as git cl lint asked: chrome/browser/chrome

int user_index,

const std::string& expected_display_name);