Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 409743002: Make the GN Android builds goma-aware. (Closed)

Created:
6 years, 5 months ago by Dirk Pranke
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : bad version of BUILD.gn #

Patch Set 2 : working version #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/toolchain/android/BUILD.gn View 1 1 chunk +8 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
6 years, 5 months ago (2014-07-22 00:50:29 UTC) #1
brettw
lgtm https://codereview.chromium.org/409743002/diff/40001/build/toolchain/android/BUILD.gn File build/toolchain/android/BUILD.gn (right): https://codereview.chromium.org/409743002/diff/40001/build/toolchain/android/BUILD.gn#newcode35 build/toolchain/android/BUILD.gn:35: if (use_goma) { This narrower scoping is better ...
6 years, 5 months ago (2014-07-22 17:20:22 UTC) #2
Dirk Pranke
On 2014/07/22 17:20:22, brettw wrote: > https://codereview.chromium.org/409743002/diff/40001/build/toolchain/android/BUILD.gn#newcode35 > build/toolchain/android/BUILD.gn:35: if (use_goma) { > This narrower ...
6 years, 5 months ago (2014-07-22 17:33:26 UTC) #3
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 5 months ago (2014-07-22 17:33:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/409743002/40001
6 years, 5 months ago (2014-07-22 17:34:48 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:35:06 UTC) #6
Message was sent while issue was closed.
Change committed as 284756

Powered by Google App Engine
This is Rietveld 408576698