Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 409723004: mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland) (Closed)

Created:
6 years, 5 months ago by erikchen
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: [Yosemite] Fix bug where zoom button causes fullscreen mode. (reland) ----------------Reland Description--------------------------- Fix a type error. NSArray comparators return a NSComparisonResult. ----------------Original CL Description--------------------------- In Yosemite, holding down alt while clicking the fullscreen button is supposed to zoom the window. This doesn't work because Chrome violates unstated AppKit assumptions. The problem seems to lie in hit testing the location of the zoom button. Reordering the subviews by moving the tab strip and the content view behind the zoom button fixes the problem. BUG=393808 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284798

Patch Set 1 : Copy of patch set 5 from https://codereview.chromium.org/402443003 #

Patch Set 2 : Fix type error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/version_independent_window.mm View 1 3 chunks +41 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
erikchen
shess: PTAL The asan try bots are down.
6 years, 5 months ago (2014-07-22 18:21:47 UTC) #1
Scott Hess - ex-Googler
lgtm
6 years, 5 months ago (2014-07-22 18:24:52 UTC) #2
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 5 months ago (2014-07-22 19:54:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/409723004/20001
6 years, 5 months ago (2014-07-22 19:56:00 UTC) #4
commit-bot: I haz the power
Change committed as 284798
6 years, 5 months ago (2014-07-22 23:23:19 UTC) #5
erikchen
6 years, 4 months ago (2014-07-29 01:30:00 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/420323009/ by erikchen@chromium.org.

The reason for reverting is: [Cocoa Exception] NSInvalidArgumentException reason
Unlocking Focus on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#>	

https://code.google.com/p/chromium/issues/detail?id=397089.

Powered by Google App Engine
This is Rietveld 408576698