Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 409723002: Revert of Fix Performance::now() for browser navigations. (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
Reviewers:
clamy, Nate Chapin, tonyg, ppi
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org, tonyg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Fix Performance::now() for browser navigations. (https://codereview.chromium.org/379873002/) Reason for revert: Broke org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest#testDoubleNavigateDoesNotSuppressInitialNavigate on the Android test bots. See http://crbug.com/395817 . Original issue's description: > Fix Performance::now() for browser navigations. > > Performance::now() is defined[1] as number of milliseconds since > navigationStart. It works correctly for renderer-initiated navigations, > but for browser-initiated ones we override the navigationStart with the > recording taken on the browser side and this is not represented in > Performace::now(). > > Among other reasons to be sad about this, this bug makes Chromium's > pagecyclers not represent the renderer initialization times in their > plt measurements. > > This patch fixes this by adjusting the fields that are supposed to > correspond to navigationStart when we change navigationStart from the > embedder. > > [1] http://www.w3.org/TR/hr-time/#dom-performance-now > > BUG=376004 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178558 TBR=clamy@chromium.org,japhet@chromium.org,tonyg@chromium.org,ppi@chromium.org NOTREECHECKS=true NOTRY=true BUG=376004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/core/loader/DocumentLoadTiming.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Kasting
Created Revert of Fix Performance::now() for browser navigations.
6 years, 5 months ago (2014-07-21 23:22:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/409723002/1
6 years, 5 months ago (2014-07-21 23:23:25 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 23:24:14 UTC) #3
Message was sent while issue was closed.
Change committed as 178601

Powered by Google App Engine
This is Rietveld 408576698