Issue 409673003: Fix unnecessary use of int64 for frame routing IDs in WebRequestAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409673003: Fix unnecessary use of int64 for frame routing IDs in WebRequestAPI (Closed)

Created:
6 years, 5 months ago by dcheng

Modified:
6 years, 5 months ago

Reviewers:
Matt Perry

CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, site-isolation-dev_chromium.org, vabr (Chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix unnecessary use of int64 for frame routing IDs in WebRequestAPI BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284601

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	chrome/browser/extensions/api/web_request/web_request_api.cc	View		5 chunks	+10 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

dcheng

I'm not familiar with the web request API. But from a quick inspection of the ...

6 years, 5 months ago (2014-07-21 21:31:30 UTC) #1

Matt Perry

+vabr for FYI LGTM. Good point about frame IDs. Something to think about.

6 years, 5 months ago (2014-07-21 21:41:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/409673003/1

6 years, 5 months ago (2014-07-21 21:50:28 UTC) #4

Message was sent while issue was closed.

Change committed as 284601