components/gcm_driver/gcm_stats_recorder_impl_unittest.cc - Issue 409653004: Record latencies of connection and arrival of first message in UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

Issue 409653004: Record latencies of connection and arrival of first message in UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes test failures. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

diff --git a/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc b/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

index 95fbbbf216a1ccced6c77b61942e9b7e64b3c978..f32ca95ddfadeeda8b9a831ab822a79024ac0958 100644

--- a/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

+++ b/components/gcm_driver/gcm_stats_recorder_impl_unittest.cc

@@ -485,6 +485,8 @@ TEST_F(GCMStatsRecorderImplTest, RegistrationTest) {

}

TEST_F(GCMStatsRecorderImplTest, RecordReceivingTest) {

+ recorder_.RecordConnectionInitiated(std::string());

+ recorder_.RecordConnectionSuccess();

recorder_.RecordDataMessageReceived(kAppId, kFrom, kByteSize, true,

GCMStatsRecorder::DATA_MESSAGE);

VerifyRecordedReceivingCount(1);

« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »