Now able to set the localMatrix when creating a SkShader from a SkImage

Now able to set the localMatrix when creating a SkShader from a SkImage

BUG=skia:2771
Committed: https://skia.googlesource.com/skia/+/76d5b477c92ef076374fc7ea9d551c798656bebd

[Rémi Piotaix, 2014-07-21 19:06:25]

PTAL

[Justin Novosad, 2014-07-21 19:20:39]

Please add a test that exercises the new code.

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h#newco...
include/core/SkImage.h:61: virtual SkShader* newShader(SkShader::TileMode,
SkShader::TileMode, SkMatrix* localMatrix = NULL) const;
Should be 'const'

https://codereview.chromium.org/409653003/diff/1/src/image/SkImage_Base.h
File src/image/SkImage_Base.h (right):

https://codereview.chromium.org/409653003/diff/1/src/image/SkImage_Base.h#new...
src/image/SkImage_Base.h:34: virtual SkShader* onNewShader(SkShader::TileMode,
SkShader::TileMode, SkMatrix* localMatrix = NULL) const { return NULL; };
No need for a default value since this is not exposed externally. Same thing for
the derived classes.

[bsalomon, 2014-07-21 19:28:41]

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h#newco...
include/core/SkImage.h:61: virtual SkShader* newShader(SkShader::TileMode,
SkShader::TileMode, SkMatrix* localMatrix = NULL) const;
On 2014/07/21 19:20:39, junov wrote:
> Should be 'const'

Also, should wrap to be <= 100 cols.

[Rémi Piotaix, 2014-07-22 19:08:08]

Test added

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h
File include/core/SkImage.h (right):

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h#newco...
include/core/SkImage.h:61: virtual SkShader* newShader(SkShader::TileMode,
SkShader::TileMode, SkMatrix* localMatrix = NULL) const;
On 2014/07/21 19:20:39, junov wrote:
> Should be 'const'

Done.

https://codereview.chromium.org/409653003/diff/1/include/core/SkImage.h#newco...
include/core/SkImage.h:61: virtual SkShader* newShader(SkShader::TileMode,
SkShader::TileMode, SkMatrix* localMatrix = NULL) const;
On 2014/07/21 19:28:41, bsalomon wrote:
> On 2014/07/21 19:20:39, junov wrote:
> > Should be 'const'
> 
> Also, should wrap to be <= 100 cols.

Done.

https://codereview.chromium.org/409653003/diff/1/src/image/SkImage_Base.h
File src/image/SkImage_Base.h (right):

https://codereview.chromium.org/409653003/diff/1/src/image/SkImage_Base.h#new...
src/image/SkImage_Base.h:34: virtual SkShader* onNewShader(SkShader::TileMode,
SkShader::TileMode, SkMatrix* localMatrix = NULL) const { return NULL; };
On 2014/07/21 19:20:39, junov wrote:
> No need for a default value since this is not exposed externally. Same thing
for
> the derived classes.

Done.

[bsalomon, 2014-07-22 19:26:37]

lgtm

[Justin Novosad, 2014-07-22 20:19:17]

lgtm

[Rémi Piotaix, 2014-07-22 21:24:26]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-07-22 21:24:53]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/piotaixr@chromium.org/409653003/20001

[commit-bot: I haz the power, 2014-07-22 21:36:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[commit-bot: I haz the power, 2014-07-22 21:46:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 21:46:14]

Try jobs failed on following builders:
  Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds...)

[Rémi Piotaix, 2014-07-22 21:49:37]

The CQ bit was checked by piotaixr@chromium.org

[commit-bot: I haz the power, 2014-07-22 21:49:53]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/piotaixr@chromium.org/409653003/40001

[commit-bot: I haz the power, 2014-07-22 22:02:20]

Change committed as 76d5b477c92ef076374fc7ea9d551c798656bebd