Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 409643002: Remove DEPRECATED extension notification from desktop_notification_service.* (Closed)

Created:
6 years, 5 months ago by limasdf
Modified:
6 years, 5 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use ExtensionRegistryObserver instead of DEPRECATED extension notify from desktop_notification_service.* BUG=354458 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284853

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M chrome/browser/notifications/desktop_notification_service.h View 1 5 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 4 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
limasdf
When you have time.
6 years, 5 months ago (2014-07-22 16:02:33 UTC) #1
Dmitry Titov
lgtm with a nit. https://codereview.chromium.org/409643002/diff/60001/chrome/browser/notifications/desktop_notification_service.h File chrome/browser/notifications/desktop_notification_service.h (right): https://codereview.chromium.org/409643002/diff/60001/chrome/browser/notifications/desktop_notification_service.h#newcode191 chrome/browser/notifications/desktop_notification_service.h:191: // Listen extension uninstalled. The ...
6 years, 5 months ago (2014-07-22 17:43:01 UTC) #2
limasdf
Thanks for the review! https://codereview.chromium.org/409643002/diff/60001/chrome/browser/notifications/desktop_notification_service.h File chrome/browser/notifications/desktop_notification_service.h (right): https://codereview.chromium.org/409643002/diff/60001/chrome/browser/notifications/desktop_notification_service.h#newcode191 chrome/browser/notifications/desktop_notification_service.h:191: // Listen extension uninstalled. On ...
6 years, 5 months ago (2014-07-22 18:15:42 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 5 months ago (2014-07-22 18:15:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/409643002/80001
6 years, 5 months ago (2014-07-22 18:17:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 21:31:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 22:47:56 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 22:48:12 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31045)
6 years, 5 months ago (2014-07-22 22:48:21 UTC) #9
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 5 months ago (2014-07-22 23:59:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/409643002/80001
6 years, 5 months ago (2014-07-23 00:01:01 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 01:59:56 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 06:08:12 UTC) #13
Message was sent while issue was closed. 
Change committed as 284853

Powered by Google App Engine
This is Rietveld 408576698