Issue 409603002: Reduce usage of StoreMode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409603002: Reduce usage of StoreMode. (Closed)

Created:
6 years, 5 months ago by Toon Verwaest

Modified:
6 years, 5 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Reduce usage of StoreMode. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22511

Patch Set 2 : Addressed comments #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -67 lines)			Patch
M	src/objects.h	View	1	3 chunks	+6 lines, -17 lines	0 comments	Download
M	src/objects.cc	View	1	12 chunks	+24 lines, -41 lines	0 comments	Download
M	src/runtime.cc	View	1	6 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/409603002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/409603002/diff/1/src/objects.cc#newcode1873 src/objects.cc:1873: PropertyAttributes attributes, StoreMode mode, The ...

6 years, 5 months ago (2014-07-21 12:17:31 UTC) #2

Toon Verwaest

6 years, 5 months ago (2014-07-21 16:01:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22511 (presubmit successful).

Expand Messages | Collapse Messages

Issue 409603002: Reduce usage of StoreMode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments #

Messages