Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 409593002: Get ResourceType from WebURLRequest rather than TargetType. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Get ResourceType from WebURLRequest rather than TargetType. 'WebURLRequest::TargetType' has been dropped in Blink in favor of 'RequestContext' and 'FrameType', matching the Fetch specification's changes, and allowing both more granularity in various Blink-side checks and more clarity around the thing that caused a request, and the frame that the request affects. This CL should have zero practical effect, as it's simply hoisting the translation work that 'WebURLRequest::targetType' is already doing up into the content layer to bring us one step closer to removing the concept entirely. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284924

Patch Set 1 #

Patch Set 2 : Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -32 lines) Patch
M content/child/web_url_loader_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/common/resource_type.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/resource_type.cc View 1 1 chunk +94 lines, -28 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
Hi Darin. Here's another CL in the series. -mike
6 years, 5 months ago (2014-07-21 16:14:45 UTC) #1
Mike West
Jochen, would you mind taking a look at this? -mike
6 years, 5 months ago (2014-07-23 08:46:42 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-23 09:10:10 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-23 09:21:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/409593002/1
6 years, 5 months ago (2014-07-23 09:22:21 UTC) #5
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-23 09:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/409593002/20001
6 years, 5 months ago (2014-07-23 09:37:20 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 14:41:51 UTC) #8
Message was sent while issue was closed.
Change committed as 284924

Powered by Google App Engine
This is Rietveld 408576698