Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 409583002: Remove 'WebURLRequest::TargetType' from WebURLLoader. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen (gone - plz use gerrit), darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

Remove 'WebURLRequest::TargetType' from WebURLLoader. 'WebURLRequest::TargetType' has been dropped in Blink in favor of 'RequestContext' and 'FrameType', matching the Fetch specification's changes, and allowing both more granularity in various Blink-side checks and more clarity around the thing that caused a request, and the frame that the request affects. This CL should have zero practical effect, as it's simply hoisting the translation work that 'WebURLRequest::setTargetType' is already doing up into the content layer to bring us one step closer to removing the concept entirely. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/child/web_url_loader_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Brett, mind taking a look at this CL? darin@/jochen@ FYI, since you're on all the ...
6 years, 5 months ago (2014-07-21 16:16:18 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-21 20:20:38 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-22 04:31:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/409583002/1
6 years, 5 months ago (2014-07-22 04:32:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 06:25:16 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 06:53:43 UTC) #6
Message was sent while issue was closed.
Change committed as 284639

Powered by Google App Engine
This is Rietveld 408576698