chrome/app/app-Info.plist - Issue 409543005: Register Chrome as MHTML Viewer on Mac OS X.

Side by Side Diff: chrome/app/app-Info.plist

Issue 409543005: Register Chrome as MHTML Viewer on Mac OS X. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>CFBundleDevelopmentRegion</key>	5 <key>CFBundleDevelopmentRegion</key>

6 <string>en</string>	6 <string>en</string>

7 <key>CFBundleDisplayName</key>	7 <key>CFBundleDisplayName</key>

8 <string>${EXECUTABLE_NAME}</string>	8 <string>${EXECUTABLE_NAME}</string>

9 <key>CFBundleDocumentTypes</key>	9 <key>CFBundleDocumentTypes</key>

10 <array>	10 <array>

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 <key>CFBundleTypeOSTypes</key>	45 <key>CFBundleTypeOSTypes</key>

46 <array>	46 <array>

47 <string>HTML</string>	47 <string>HTML</string>

48 </array>	48 </array>

49 <key>CFBundleTypeRole</key>	49 <key>CFBundleTypeRole</key>

50 <string>Viewer</string>	50 <string>Viewer</string>

51 </dict>	51 </dict>

52 <dict>	52 <dict>

53 <key>CFBundleTypeExtensions</key>	53 <key>CFBundleTypeExtensions</key>

54 <array>	54 <array>

	55 <string>mhtml</string>
	Mark Mentovai 2014/07/21 18:32:16 xhtml and one or two others are maybe in a bad spo xhtml and one or two others are maybe in a bad spot, but this list is generally sorted by the primary extension. You should move this entry to be between jpg and ogg. Mark Mentovai 2014/07/21 18:32:16 Your CL description says something about a flag. C Your CL description says something about a flag. Can you confirm that Chrome is able to open MHTML files even when that flag is not present? benjhayden 2014/07/21 18:41:49 The flag only controls whether chrome saves the pa Show quoted text On 2014/07/21 18:32:16, Mark Mentovai wrote: > Your CL description says something about a flag. Can you confirm that Chrome is > able to open MHTML files even when that flag is not present? The flag only controls whether chrome saves the page as mhtml, not whether chrome can open mhtml files. https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/dow... Chrome should be able to open mhtml files regardless of that flag, or any other afaik. benjhayden 2014/07/21 18:41:49 Done. Show quoted text On 2014/07/21 18:32:16, Mark Mentovai wrote: > xhtml and one or two others are maybe in a bad spot, but this list is generally > sorted by the primary extension. You should move this entry to be between jpg > and ogg. Done.
	56 <string>mht</string>

	57 </array>

	58 <key>CFBundleTypeIconFile</key>

	59 <string>document.icns</string>

	60 <key>CFBundleTypeMIMETypes</key>

	61 <array>

	62 <string>multipart/related</string>
	Mark Mentovai 2014/07/21 18:32:16 http://en.wikipedia.org/wiki/MHTML shows two more http://en.wikipedia.org/wiki/MHTML shows two more MIME types. Should those be listed too? benjhayden 2014/07/21 18:41:49 Done. Show quoted text On 2014/07/21 18:32:16, Mark Mentovai wrote: > http://en.wikipedia.org/wiki/MHTML shows two more MIME types. Should those be > listed too? Done.
	63 </array>

	64 <key>CFBundleTypeName</key>

	65 <string>MHTML document</string>

	66 <key>CFBundleTypeOSTypes</key>
	Mark Mentovai 2014/07/21 18:32:16 Don’t specify this at all. An OSType is a 32-bit i Don’t specify this at all. An OSType is a 32-bit integer normally represented as four ASCII characters. It relates to the classic Mac file type code that’s set for the file. MHTML is not a valid OS file type code, and it’s likely that there is no code that’s properly used for this file type, so you should just leave this key and array out entirely. benjhayden 2014/07/21 18:41:49 Done. Show quoted text On 2014/07/21 18:32:16, Mark Mentovai wrote: > Don’t specify this at all. An OSType is a 32-bit integer normally represented as > four ASCII characters. It relates to the classic Mac file type code that’s set > for the file. MHTML is not a valid OS file type code, and it’s likely that there > is no code that’s properly used for this file type, so you should just leave > this key and array out entirely. Done.
	67 <array>

	68 <string>MHTML</string>

	69 </array>

	70 <key>CFBundleTypeRole</key>

	71 <string>Viewer</string>

	72 </dict>

	73 <dict>

	74 <key>CFBundleTypeExtensions</key>

	75 <array>

55 <string>xhtml</string>	76 <string>xhtml</string>

56 </array>	77 </array>

57 <key>CFBundleTypeIconFile</key>	78 <key>CFBundleTypeIconFile</key>

58 <string>document.icns</string>	79 <string>document.icns</string>

59 <key>CFBundleTypeMIMETypes</key>	80 <key>CFBundleTypeMIMETypes</key>

60 <array>	81 <array>

61 <string>text/xhtml</string>	82 <string>text/xhtml</string>

62 </array>	83 </array>

63 <key>CFBundleTypeName</key>	84 <key>CFBundleTypeName</key>

64 <string>XHTML document</string>	85 <string>XHTML document</string>

(...skipping 255 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
320 <dict>	341 <dict>

321 <key>public.filename-extension</key>	342 <key>public.filename-extension</key>

322 <array>	343 <array>

323 <string>crx</string>	344 <string>crx</string>

324 </array>	345 </array>

325 </dict>	346 </dict>

326 </dict>	347 </dict>

327 </array>	348 </array>

328 </dict>	349 </dict>

329 </plist>	350 </plist>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »