Add constructor for range types.

Add constructor for range types.

R=rossberg@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=22535

[rossberg, 2014-07-21 15:58:32]

https://codereview.chromium.org/409543004/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/409543004/diff/1/src/types.cc#newcode915
src/types.cc:915: os << "Range([" << this->AsRange()->Min()
Let's print this as

  Range(0.5..1.7 : bound)

to avoid too many parentheses.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:164: for (int i = 0; i < 40; ++i) {
I suppose 10 to 20 is enough here, esp given that the test is O(N^4) below.
Also, maybe make half the random numbers proper integers, since that will likely
be the common case in practice.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:598: double min = *i <= *j ? *i : *j;
You can use the C++ min & max functions for these.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:616: // Injectivity: Range(min1, max1) = Range(min2,
max2) =>
I think that Functionality should hold as well.

[neis, 2014-07-21 17:47:15]

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:44: }
This was bogus and I got rid of it.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:164: for (int i = 0; i < 40; ++i) {
On 2014/07/21 15:58:32, rossberg wrote:
> I suppose 10 to 20 is enough here, esp given that the test is O(N^4) below.
> Also, maybe make half the random numbers proper integers, since that will
likely
> be the common case in practice.

Done.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:598: double min = *i <= *j ? *i : *j;
On 2014/07/21 15:58:32, rossberg wrote:
> You can use the C++ min & max functions for these.

Done.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:616: // Injectivity: Range(min1, max1) = Range(min2,
max2) =>
On 2014/07/21 15:58:32, rossberg wrote:
> I think that Functionality should hold as well.

Right.  Actually, the changes to Equal were incomplete.  I fixed that but I had
to disable the test for now because it fails as long as subtyping is not yet
defined for range types.

[rossberg, 2014-07-22 07:58:36]

LGTM, modulo the two nits below.

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:616: // Injectivity: Range(min1, max1) = Range(min2,
max2) =>
On 2014/07/21 17:47:15, neis wrote:
> On 2014/07/21 15:58:32, rossberg wrote:
> > I think that Functionality should hold as well.
> 
> Right.  Actually, the changes to Equal were incomplete.  I fixed that but I
had
> to disable the test for now because it fails as long as subtyping is not yet
> defined for range types.

Might be worth including the test anyway for clarity, but commented out and with
a TODO.

https://codereview.chromium.org/409543004/diff/20001/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/409543004/diff/20001/test/cctest/test-types.c...
test/cctest/test-types.cc:596: TypeHandle type = T.Range(std::min(*i, *j),
std::max(*i, *j));
Nit: also bind min & max to variables, for consistency with below.

[neis, 2014-07-22 08:34:46]

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/409543004/diff/1/test/cctest/test-types.cc#ne...
test/cctest/test-types.cc:616: // Injectivity: Range(min1, max1) = Range(min2,
max2) =>
On 2014/07/22 07:58:35, rossberg wrote:
> On 2014/07/21 17:47:15, neis wrote:
> > On 2014/07/21 15:58:32, rossberg wrote:
> > > I think that Functionality should hold as well.
> > 
> > Right.  Actually, the changes to Equal were incomplete.  I fixed that but I
> had
> > to disable the test for now because it fails as long as subtyping is not yet
> > defined for range types.
> 
> Might be worth including the test anyway for clarity, but commented out and
with
> a TODO.

Done.

https://codereview.chromium.org/409543004/diff/20001/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/409543004/diff/20001/test/cctest/test-types.c...
test/cctest/test-types.cc:596: TypeHandle type = T.Range(std::min(*i, *j),
std::max(*i, *j));
On 2014/07/22 07:58:36, rossberg wrote:
> Nit: also bind min & max to variables, for consistency with below.

Done.

[neis, 2014-07-22 14:03:55]

Turns out an ASSERT needed updating.  Please have another look.

[rossberg, 2014-07-22 14:19:10]

Still LGTM

[neis, 2014-07-22 17:33:29]

Committed patchset #4 manually as r22535 (presubmit successful).