Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: Tools/TestResultServer/static-dashboards/history.js

Issue 409523002: Allow both the ChromiumLinux and chromium.linux formats for the master parameter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/TestResultServer/static-dashboards/history.js
diff --git a/Tools/TestResultServer/static-dashboards/history.js b/Tools/TestResultServer/static-dashboards/history.js
index 023f6417e420f0b27456cd54a2b08b50f73a4dcc..7406f74e087a4fda96faec04b18d64825d8be4c0 100644
--- a/Tools/TestResultServer/static-dashboards/history.js
+++ b/Tools/TestResultServer/static-dashboards/history.js
@@ -71,21 +71,21 @@ history.queryHashAsMap = function()
paramsMap[thisParam[0]] = decodeURIComponent(thisParam[1]);
}
- // FIXME: remove support for mapping from the master parameter to the group
- // one once the waterfall starts to pass in the builder name instead.
+ // FIXME: Make master a first-class parameter instead of replacing it with the group.
if (paramsMap.master) {
var errors = new ui.Errors();
if (paramsMap.master == 'TryServer')
errors.addError('ERROR: You got here from the trybot waterfall. The try bots do not record data in the flakiness dashboard. Showing results for the regular waterfall.');
- else if (!builders.masters[paramsMap.master])
+ else if (!builders.masters[paramsMap.master] && !builders.urlNameToMasterName[paramsMap.master])
errors.addError('ERROR: Unknown master name: ' + paramsMap.master);
if (errors.hasErrors()) {
errors.show();
window.location.hash = window.location.hash.replace('master=' + paramsMap.master, '');
} else {
- var groupIndex = paramsMap.master == 'ChromiumWebkit' ? 1 : 0;
- paramsMap.group = builders.masters[paramsMap.master].groups[groupIndex];
+ var master = builders.urlNameToMasterName[paramsMap.master] || paramsMap.master;
+ var groupIndex = master == 'ChromiumWebkit' ? 1 : 0;
+ paramsMap.group = builders.masters[master].groups[groupIndex];
window.location.hash = window.location.hash.replace('master=' + paramsMap.master, 'group=' + encodeURIComponent(paramsMap.group));
delete paramsMap.master;
}

Powered by Google App Engine
This is Rietveld 408576698