Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 409523002: Allow both the ChromiumLinux and chromium.linux formats for the master parameter. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 5 months ago
CC:
blink-reviews, szager1
Project:
blink
Visibility:
Public.

Description

Allow both the ChromiumLinux and chromium.linux formats for the master parameter. Also, fix the styling of FAIL failure types now that gtests use that instead of having FAIL masquerade as TEXT. BUG=395496 R=pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178538

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M Tools/TestResultServer/static-dashboards/builders.js View 1 chunk +2 lines, -0 lines 2 comments Download
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css View 1 chunk +1 line, -1 line 0 comments Download
M Tools/TestResultServer/static-dashboards/history.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ojan
6 years, 5 months ago (2014-07-21 03:57:32 UTC) #1
pdr.
LGTM with a nit. https://codereview.chromium.org/409523002/diff/1/Tools/TestResultServer/static-dashboards/builders.js File Tools/TestResultServer/static-dashboards/builders.js (right): https://codereview.chromium.org/409523002/diff/1/Tools/TestResultServer/static-dashboards/builders.js#newcode38 Tools/TestResultServer/static-dashboards/builders.js:38: builders.urlNameToMasterName[master.url_name] = master.name Add a ...
6 years, 5 months ago (2014-07-21 06:17:34 UTC) #2
ojan
https://codereview.chromium.org/409523002/diff/1/Tools/TestResultServer/static-dashboards/builders.js File Tools/TestResultServer/static-dashboards/builders.js (right): https://codereview.chromium.org/409523002/diff/1/Tools/TestResultServer/static-dashboards/builders.js#newcode38 Tools/TestResultServer/static-dashboards/builders.js:38: builders.urlNameToMasterName[master.url_name] = master.name On 2014/07/21 06:17:34, pdr wrote: > ...
6 years, 5 months ago (2014-07-21 06:29:14 UTC) #3
ojan
Committed patchset #1 manually as r178538 (presubmit successful).
6 years, 5 months ago (2014-07-21 06:29:48 UTC) #4
eseidel
Am I doing this right? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=MultiProfileDriveFileSystemExtensionApiTest.CrossProfileCopy&master=chromium.chromiumos
6 years, 5 months ago (2014-07-21 16:49:35 UTC) #5
ojan
6 years, 5 months ago (2014-07-21 18:33:09 UTC) #6
Message was sent while issue was closed. 
On 2014/07/21 at 16:49:35, eseidel wrote:
> Am I doing this right?
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=...

I hadn't pushed the new server yet. This link works now.

Powered by Google App Engine
This is Rietveld 408576698