Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 409493002: Cleanup test_support target names. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, ben+aura_chromium.org, tdresser+watch_chromium.org, jam, sadrul, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, awong, jamesr, scottmg
Project:
chromium
Visibility:
Public.

Description

Cleanup test_support target names. In GN it is redundat to include the parent directory name, as in ui/gfx:gfx_test_support. Instead we can write it as ui/gfx:test_support which is shorter and nicer to read. Targets found with the following command line: $ for f in $(g ls-files | grep BUILD); do grep _test_support $f; echo $f; done BUG=None TEST=None R=brettw@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M dbus/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/BUILD.gn View 7 chunks +9 lines, -9 lines 0 comments Download
M printing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 4 chunks +7 lines, -7 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
6 years, 5 months ago (2014-07-20 16:00:23 UTC) #1
brettw
Nice LGTM
6 years, 5 months ago (2014-07-21 04:33:22 UTC) #2
tfarina
6 years, 5 months ago (2014-07-22 23:27:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r284800 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698