Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 409483002: Cleanup DrawingBuffer::paintCompositingResultsToCanvas (Closed)

Created:
6 years, 5 months ago by hj.r.chung
Modified:
6 years, 5 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup DrawingBuffer::paintCompositingResultsToCanvas Remove the unnecessary copyTexture and use the value tracked by WebGLRenderingContext when restoring the framebuffer binding instead of querying GL_FRAMEBUFFER_BINDING. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178723

Patch Set 1 #

Patch Set 2 : remove unnecessary copyTexture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 1 chunk +4 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hj.r.chung
This is a simple cleanup patch. PTAL!
6 years, 5 months ago (2014-07-21 00:35:50 UTC) #1
hj.r.chung
This is a simple cleanup patch. PTAL!
6 years, 5 months ago (2014-07-21 00:35:52 UTC) #2
Ken Russell (switch to Gerrit)
This looks good, but please do a full layout test run and make sure this ...
6 years, 5 months ago (2014-07-22 02:00:30 UTC) #3
hj.r.chung
On 2014/07/22 02:00:30, Ken Russell wrote: > This looks good, but please do a full ...
6 years, 5 months ago (2014-07-22 04:07:49 UTC) #4
Ken Russell (switch to Gerrit)
OK. LGTM
6 years, 5 months ago (2014-07-22 18:32:45 UTC) #5
hj.r.chung
On 2014/07/22 18:32:45, Ken Russell wrote: > OK. LGTM Thank you!
6 years, 5 months ago (2014-07-23 02:07:50 UTC) #6
hj.r.chung
The CQ bit was checked by heejin.r.chung@samsung.com
6 years, 5 months ago (2014-07-23 02:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/409483002/20001
6 years, 5 months ago (2014-07-23 02:08:33 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 03:14:00 UTC) #9
Message was sent while issue was closed.
Change committed as 178723

Powered by Google App Engine
This is Rietveld 408576698