Issue 409473002: A bit of element model cleanup.

Issue 409473002: A bit of element model cleanup. (Closed)

Created:
6 years, 5 months ago by Johnni Winther

Modified:
6 years, 5 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

A bit of element model cleanup. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38493

Patch Set 2 : Updated cf. comments. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -76 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/closure.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1	5 chunks	+37 lines, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		8 chunks	+0 lines, -53 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/registry.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/409473002/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/409473002/diff/1/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode298 sdk/lib/_internal/compiler/implementation/elements/elements.dart:298: /// `true` if this element represents an entity ...

6 years, 5 months ago (2014-07-21 08:55:34 UTC) #2

Johnni Winther

Committed patchset #2 manually as r38493 (presubmit successful).

6 years, 5 months ago (2014-07-23 11:18:52 UTC) #3

Johnni Winther

6 years, 5 months ago (2014-07-23 12:49:41 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/409473002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/409473002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:298: /// `true`
if this element represents an entity whose access should cause
On 2014/07/21 08:55:34, floitsch wrote:
> If our compiler is correct it always reports the warning. So maybe:
> 
> ".. whose access causes one or more warnings."

Done.

https://codereview.chromium.org/409473002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:792: ///    
Element.isUnresolved(element)
On 2014/07/21 08:55:34, floitsch wrote:
> I would use backticks. `Element.isUnresolved(element)` to check for ...
instead
> of `element == null`.
> 
> Otherwise you have to add new lines around the code blocks.

Done.

https://codereview.chromium.org/409473002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:816: /// an
ambiguous element is encountered during resolution a warning/error should
On 2014/07/21 08:55:34, floitsch wrote:
> same remark (about "should") as above.

Done.

Expand Messages | Collapse Messages