Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 409423002: Add osmesa to GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add osmesa to GN build. Rename gpu_unittest_utils test_utils for project consistency. Add angle unit tests. Update comments in GPU GYP file referencing GN targets. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285067

Patch Set 1 #

Patch Set 2 : git branch #

Patch Set 3 : add some extra refs, don't compile on Android. #

Patch Set 4 : mergey wergey #

Patch Set 5 : really mergey wergey #

Patch Set 6 : Fix GN #

Patch Set 7 : android #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -129 lines) Patch
M cc/BUILD.gn View 1 2 3 4 5 6 4 chunks +7 lines, -5 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M gpu/BUILD.gn View 1 2 4 chunks +21 lines, -3 lines 0 comments Download
M gpu/gpu.gyp View 24 chunks +24 lines, -0 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +120 lines, -112 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
Committed patchset #8 manually as r285067.
6 years, 5 months ago (2014-07-23 22:35:15 UTC) #1
jamesr
6 years, 5 months ago (2014-07-23 22:38:17 UTC) #2
Message was sent while issue was closed.
lgtm

we should probably remove */state_tracker/* from the gyp build too

Powered by Google App Engine
This is Rietveld 408576698