Source/bindings/tests/idls/TestDictionary.idl - Issue 409373002: IDL: Binding code generation for dictionaries

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/tests/idls/TestDictionary.idl

Issue 409373002: IDL: Binding code generation for dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4

5 [	4 [

6 NoInterfaceObject,	5 GarbageCollected,

7 WillBeGarbageCollected,	6 ] dictionary TestDictionary {

8 ] interface EXTShaderTextureLOD {	7 boolean booleanMember;

	8 long longMember = 1;
	haraken 2014/07/23 15:49:01 Would you add a bit more test cases? Although you Would you add a bit more test cases? Although you don't need to cover all types, you might want to add more things you've already supported. bashi 2014/07/25 01:59:02 Added string, interface, nullable cases. I didn't Show quoted text On 2014/07/23 15:49:01, haraken wrote: > > Would you add a bit more test cases? Although you don't need to cover all types, > you might want to add more things you've already supported. Added string, interface, nullable cases. I didn't add array and sequence cases because I'm not sure they work for all types (e.g. sequence<SomeInterface>).
9 };	9 };

OLD	NEW