Issue 409353002: Files.app: handle UNSUPPORTED_FILESYSTEM errors.

Issue 409353002: Files.app: handle UNSUPPORTED_FILESYSTEM errors. (Closed)

Created:
6 years, 5 months ago by kinaba

Modified:
6 years, 5 months ago

Reviewers:
benwells, hirono

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Files.app: handle UNSUPPORTED_FILESYSTEM errors. * Correct spelling in several places. * Add handling of the error during onMountCompleted event so that the volume shows up in UI and users can format it. BUG=396531 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285501

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fix. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/event_router.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/file_browser_private.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/file_manager/unit_tests/device_handler_unittest.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/file_manager/file_manager/background/js/device_handler.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/file_manager/file_manager/background/js/volume_manager.js	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

hirono

lgtm with a nit! https://codereview.chromium.org/409353002/diff/1/ui/file_manager/file_manager/background/js/volume_manager.js File ui/file_manager/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/409353002/diff/1/ui/file_manager/file_manager/background/js/volume_manager.js#newcode582 ui/file_manager/file_manager/background/js/volume_manager.js:582: var error = event.status === ...

6 years, 5 months ago (2014-07-23 09:09:04 UTC) #2

kinaba

https://codereview.chromium.org/409353002/diff/1/ui/file_manager/file_manager/background/js/volume_manager.js File ui/file_manager/file_manager/background/js/volume_manager.js (right): https://codereview.chromium.org/409353002/diff/1/ui/file_manager/file_manager/background/js/volume_manager.js#newcode582 ui/file_manager/file_manager/background/js/volume_manager.js:582: var error = event.status === 'success' ? '' : ...

6 years, 5 months ago (2014-07-23 09:17:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/409353002/20001

6 years, 5 months ago (2014-07-25 05:21:28 UTC) #6

Message was sent while issue was closed.

Change committed as 285501

Expand Messages | Collapse Messages