Oilpan: WebAudio: Prepare to move AudioProcessor hierarchy to Oilpan heap.

Oilpan: WebAudio: Prepare to move AudioProcessor hierarchy to Oilpan heap.

This CL removes five Persistent handles to AudioParam.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178768

[tkent, 2014-07-23 02:20:37]

Please review this straight-forward change.

[haraken, 2014-07-23 03:09:49]

LGTM

https://codereview.chromium.org/409303002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioBasicProcessorNode.cpp (right):

https://codereview.chromium.org/409303002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioBasicProcessorNode.cpp:65: void
AudioBasicProcessorNode::uninitialize()

Hmm, this looks safe but fragile.

uninitialize() is sometimes called from destructors of the AudioNode hierarchy.
If this uninitialize() is called in some destructor, it causes a
touch-another-on-heap-object-in-destructor issue because it touches m_processor.
However, this uninitialize() is safe by accident because it is currently not
called in any destructor. It looks a bit fragile to rely on the assumption.

[tkent, 2014-07-23 03:38:42]

https://codereview.chromium.org/409303002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioBasicProcessorNode.cpp (right):

https://codereview.chromium.org/409303002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioBasicProcessorNode.cpp:65: void
AudioBasicProcessorNode::uninitialize()
On 2014/07/23 03:09:49, haraken wrote:
> 
> Hmm, this looks safe but fragile.
> 
> uninitialize() is sometimes called from destructors of the AudioNode
hierarchy.
> If this uninitialize() is called in some destructor, it causes a
> touch-another-on-heap-object-in-destructor issue because it touches
m_processor.
> However, this uninitialize() is safe by accident because it is currently not
> called in any destructor. It looks a bit fragile to rely on the assumption.

I'll add ~AudioBasicProcessorNode with ASSERT(!isInitialized()).

[haraken, 2014-07-23 03:41:03]

https://codereview.chromium.org/409303002/diff/1/Source/modules/webaudio/Audi...
File Source/modules/webaudio/AudioBasicProcessorNode.cpp (right):

https://codereview.chromium.org/409303002/diff/1/Source/modules/webaudio/Audi...
Source/modules/webaudio/AudioBasicProcessorNode.cpp:65: void
AudioBasicProcessorNode::uninitialize()
On 2014/07/23 03:38:41, tkent wrote:
> On 2014/07/23 03:09:49, haraken wrote:
> > 
> > Hmm, this looks safe but fragile.
> > 
> > uninitialize() is sometimes called from destructors of the AudioNode
> hierarchy.
> > If this uninitialize() is called in some destructor, it causes a
> > touch-another-on-heap-object-in-destructor issue because it touches
> m_processor.
> > However, this uninitialize() is safe by accident because it is currently not
> > called in any destructor. It looks a bit fragile to rely on the assumption.
> 
> I'll add ~AudioBasicProcessorNode with ASSERT(!isInitialized()).

That's a nice idea.

[tkent, 2014-07-23 04:20:06]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-23 04:20:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/409303002/20001

[commit-bot: I haz the power, 2014-07-23 05:36:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-07-23 06:43:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 06:43:24]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[tkent, 2014-07-23 15:32:27]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-23 15:33:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/409303002/40001

[commit-bot: I haz the power, 2014-07-23 15:38:05]

Change committed as 178768