Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 409283003: A pointer should be sufficient for Range::compareBoundaryPoints (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

A pointer should be sufficient for Range::compareBoundaryPoints It is because this function does not save Range object to anywhere. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-23 02:20:59 UTC) #1
Yuta Kitamura
lgtm
6 years, 5 months ago (2014-07-23 08:19:48 UTC) #2
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-23 08:22:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/409283003/1
6 years, 5 months ago (2014-07-23 08:23:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 13:32:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 13:58:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31513)
6 years, 5 months ago (2014-07-23 13:58:19 UTC) #7
kangil_
The CQ bit was checked by kangil.han@samsung.com
6 years, 5 months ago (2014-07-24 00:15:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/409283003/1
6 years, 5 months ago (2014-07-24 00:16:30 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 00:17:37 UTC) #10
Message was sent while issue was closed. 
Change committed as 178790

Powered by Google App Engine
This is Rietveld 408576698