Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 409263002: Mojo: Get rid of ui::gfx from sample_app (Closed)

Created:
6 years, 5 months ago by Hajime Morrita
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Get rid of ui::gfx from sample_app This CL replaces gfx based geometry objects with ones from mojo::. TEST=none R=beng@chromium.org, viettrungluu@chromium.org BUG=330467 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M mojo/examples/sample_app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.h View 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/examples/sample_app/gles2_client_impl.cc View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Hajime Morrita
6 years, 5 months ago (2014-07-22 23:28:52 UTC) #1
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-22 23:39:30 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 5 months ago (2014-07-22 23:59:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/409263002/1
6 years, 5 months ago (2014-07-23 00:01:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 01:54:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 03:43:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31191)
6 years, 5 months ago (2014-07-23 03:43:10 UTC) #7
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 5 months ago (2014-07-23 16:39:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/409263002/1
6 years, 5 months ago (2014-07-23 16:41:27 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 16:43:34 UTC) #10
Message was sent while issue was closed.
Change committed as 284951

Powered by Google App Engine
This is Rietveld 408576698