Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 409253004: Remove 'inline' from two methods. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Remove 'inline' from two methods. The methods are only defined in the cpp and thus can't always be inlined, the methods are virtual and so can only be inlined when the concrete type is known, and inline functions need their definition available in all translation units. So just remove the 'inline'. BUG=none R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/3b07e75

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/src/fpdfdoc/pdf_vt.h View 1 chunk +2 lines, -2 lines 4 comments Download

Messages

Total messages: 11 (0 generated)
Nico
This fixes a build warning. https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h File core/src/fpdfdoc/pdf_vt.h (right): https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h#newcode522 core/src/fpdfdoc/pdf_vt.h:522: CPVT_WordPlace GetEndWordPlace() const; (do ...
6 years, 5 months ago (2014-07-23 00:51:41 UTC) #1
Nico
Bo: Ping! This is a very simple change.
6 years, 5 months ago (2014-07-24 01:06:23 UTC) #2
Nico
Bo: Ping.
6 years, 4 months ago (2014-07-28 20:55:10 UTC) #3
Nico
Bo: Ping.
6 years, 4 months ago (2014-07-28 20:55:10 UTC) #4
Nico
Argh, I hit "enter" accidentally, didn't mean to send just yet. Jun: Do you know ...
6 years, 4 months ago (2014-07-28 20:55:43 UTC) #5
Bo Xu
On 2014/07/28 20:55:43, Nico (away) wrote: > Argh, I hit "enter" accidentally, didn't mean to ...
6 years, 4 months ago (2014-07-28 21:00:08 UTC) #6
Nico
On 2014/07/28 21:00:08, Bo Xu wrote: > On 2014/07/28 20:55:43, Nico (away) wrote: > > ...
6 years, 4 months ago (2014-07-28 21:30:28 UTC) #7
Bo Xu
https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h File core/src/fpdfdoc/pdf_vt.h (right): https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h#newcode522 core/src/fpdfdoc/pdf_vt.h:522: CPVT_WordPlace GetEndWordPlace() const; On 2014/07/23 00:51:41, Nico (away) wrote: ...
6 years, 4 months ago (2014-07-28 22:00:36 UTC) #8
Nico
https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h File core/src/fpdfdoc/pdf_vt.h (right): https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h#newcode522 core/src/fpdfdoc/pdf_vt.h:522: CPVT_WordPlace GetEndWordPlace() const; On 2014/07/28 22:00:36, Bo Xu wrote: ...
6 years, 4 months ago (2014-07-28 22:01:40 UTC) #9
Bo Xu
lgtm https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h File core/src/fpdfdoc/pdf_vt.h (right): https://codereview.chromium.org/409253004/diff/1/core/src/fpdfdoc/pdf_vt.h#newcode522 core/src/fpdfdoc/pdf_vt.h:522: CPVT_WordPlace GetEndWordPlace() const; On 2014/07/28 22:01:40, Nico (away) ...
6 years, 4 months ago (2014-07-28 22:08:31 UTC) #10
Nico
6 years, 4 months ago (2014-07-28 22:23:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r3b07e75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698