Weakly bind JsonPrefStore's async read task to avoid it coming back after shutdown has been initiat…

Weakly bind JsonPrefStore's async read task to avoid it coming back after shutdown has been initiated.

BUG=393081
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285941

[gab, 2014-07-23 17:28:36]

Note: I tried to remove refcounting on PrefStore altogether, but it's no longer
true that this was the only use-case for it :-(.

In particular, it appears multiple PrefValueStores can own the same underlying
PrefStores (see PrefValueStore::CloneAndSpecialize and
PrefStoreKeeper::Initialize).

For now I'd like to at least make the read task weakly-bound without refactoring
the way PrefStore lifetime-management works (and I don't think I'll have time to
get to that shortly  unfortunately...).

Cheers,
Gab

[Bernhard Bauer, 2014-07-28 07:54:06]

LGTM

Thanks for the cleanup! Yeah, that's a pity... :-(

[gab, 2014-07-28 13:34:25]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2014-07-28 13:34:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/gab@chromium.org/409223006/20001

[commit-bot: I haz the power, 2014-07-28 17:43:21]

Change committed as 285941