Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 409183002: Revert of [oilpan]: Change marking to do precise roots first and conservative second. (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

Revert of [oilpan]: Change marking to do precise roots first and conservative second. (https://codereview.chromium.org/405403003/) Reason for revert: Broke blink_heap_unittests on http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/16773 Specifically, HeapTest.CrossThreadPointerToOrphanedPage fails with: ../../third_party/WebKit/Source/platform/heap/HeapTest.cpp:4685: Failure Value of: CrossThreadObject::s_destructorCalls Actual: 1 Expected: 0 Original issue's description: > [oilpan]: Change marking to do precise roots first and conservative second. > > This way we avoid conservatively scanning objects that were reachable through precise pointers. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com, tkent@chromium.org, zerny@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178664 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com,tkent@chromium.org,zerny@chromium.org,wibling@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -63 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 4 chunks +13 lines, -44 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 4 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
johnme
Created Revert of [oilpan]: Change marking to do precise roots first and conservative second.
6 years, 5 months ago (2014-07-22 16:25:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/409183002/1
6 years, 5 months ago (2014-07-22 16:26:28 UTC) #2
commit-bot: I haz the power
Change committed as 178671
6 years, 5 months ago (2014-07-22 16:27:07 UTC) #3
sof
lgtm, thanks for doing this. It's an interesting failure; is this particular stack reference not ...
6 years, 5 months ago (2014-07-22 21:16:46 UTC) #4
haraken
LGTM
6 years, 5 months ago (2014-07-22 23:24:41 UTC) #5
wibling-chromium
6 years, 5 months ago (2014-07-23 08:01:08 UTC) #6
Message was sent while issue was closed.
lgtm

Thanks for reverting! I will investigate...

Powered by Google App Engine
This is Rietveld 408576698