Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 409163005: Rename the CloudPrintPrinterListTest.Parsing test to PrivetConfirmApiFlowTest.Params to match the o… (Closed)

Created:
6 years, 5 months ago by jam
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Rename the CloudPrintPrinterListTest.Parsing test to PrivetConfirmApiFlowTest.Params to match the other test in that file as there's already another CloudPrintPrinterListTest.Parsing. One of them is flaking 33% of the time according to http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.win but I can't tell which one it is. TBR=vitalybuka@chromium.org BUG=386891 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/local_discovery/privet_confirm_api_flow_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 5 months ago (2014-07-23 02:46:53 UTC) #1
jam
The CQ bit was checked by jam@chromium.org
6 years, 5 months ago (2014-07-23 15:00:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/409163005/1
6 years, 5 months ago (2014-07-23 15:02:38 UTC) #3
Vitaly Buka (NO REVIEWS)
6 years, 5 months ago (2014-07-23 22:26:30 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698