ozone: Fix GN build for ozone_egl_demo, ozone_unittests

ozone: Fix GN build for ozone_egl_demo, ozone_unittests

This fixes the GN build for the ui/ozone component (and tests). The
following build should work going forward:

 gn gen out_gn_ozone --args="use_ozone=true"
 ninja -C out_gn_ozone -j1000 -k50 ozone_egl_demo ozone_unittests

BUG=396316
TEST=compile & run ozone_egl_demo, ozone_unittests
TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285362

[brettw, 2014-07-23 00:32:32]

Looks great!

https://codereview.chromium.org/409163004/diff/20001/build/config/linux/BUILD.gn
File build/config/linux/BUILD.gn (right):

https://codereview.chromium.org/409163004/diff/20001/build/config/linux/BUILD...
build/config/linux/BUILD.gn:29: packages = [ "gbm" ]
"pkg-config --libs-only-l gbm" fails on my system so this is probably not what
we want.

I think we'll want this in one of the ui/ozone directories and to surround it
with an if that defines it only if gbm is enabled.

https://codereview.chromium.org/409163004/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/409163004/diff/20001/ui/base/BUILD.gn#newcode455
ui/base/BUILD.gn:455: "cursor/cursor_loader_ozone.cc",
I just checked in:
http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/BUILD.gn?r1=281087&r2...
which does some of this (not sure if it has everything you need), so you'll want
to sync past there and see if you need to make any changes on top.

[spang, 2014-07-23 17:27:56]

https://codereview.chromium.org/409163004/diff/20001/build/config/linux/BUILD.gn
File build/config/linux/BUILD.gn (right):

https://codereview.chromium.org/409163004/diff/20001/build/config/linux/BUILD...
build/config/linux/BUILD.gn:29: packages = [ "gbm" ]
On 2014/07/23 00:32:32, brettw wrote:
> "pkg-config --libs-only-l gbm" fails on my system so this is probably not what
> we want.
> 
> I think we'll want this in one of the ui/ozone directories and to surround it
> with an if that defines it only if gbm is enabled.

We did add this library to install-build-deps.sh, but making it conditional will
probably be less disruptive without any downside. Moved.

https://codereview.chromium.org/409163004/diff/20001/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/409163004/diff/20001/ui/base/BUILD.gn#newcode455
ui/base/BUILD.gn:455: "cursor/cursor_loader_ozone.cc",
On 2014/07/23 00:32:32, brettw wrote:
> I just checked in:
>
http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/BUILD.gn?r1=281087&r2...
> which does some of this (not sure if it has everything you need), so you'll
want
> to sync past there and see if you need to make any changes on top.

Done.

[spang, 2014-07-24 17:07:46]

On 2014/07/23 17:27:56, spang wrote:
>
https://codereview.chromium.org/409163004/diff/20001/build/config/linux/BUILD.gn
> File build/config/linux/BUILD.gn (right):
> 
>
https://codereview.chromium.org/409163004/diff/20001/build/config/linux/BUILD...
> build/config/linux/BUILD.gn:29: packages = [ "gbm" ]
> On 2014/07/23 00:32:32, brettw wrote:
> > "pkg-config --libs-only-l gbm" fails on my system so this is probably not
what
> > we want.
> > 
> > I think we'll want this in one of the ui/ozone directories and to surround
it
> > with an if that defines it only if gbm is enabled.
> 
> We did add this library to install-build-deps.sh, but making it conditional
will
> probably be less disruptive without any downside. Moved.
> 
> https://codereview.chromium.org/409163004/diff/20001/ui/base/BUILD.gn
> File ui/base/BUILD.gn (right):
> 
>
https://codereview.chromium.org/409163004/diff/20001/ui/base/BUILD.gn#newcode455
> ui/base/BUILD.gn:455: "cursor/cursor_loader_ozone.cc",
> On 2014/07/23 00:32:32, brettw wrote:
> > I just checked in:
> >
>
http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/BUILD.gn?r1=281087&r2...
> > which does some of this (not sure if it has everything you need), so you'll
> want
> > to sync past there and see if you need to make any changes on top.
> 
> Done.

PTAL

[brettw, 2014-07-24 18:12:08]

lgtm

https://codereview.chromium.org/409163004/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/409163004/diff/60001/media/BUILD.gn#newcode528
media/BUILD.gn:528: inputs = [ platform_list_txt_file ]
This code is all messed up (beyond the error you're seeing here). I ran into
this problem this morning and I think this patch should fix it properly:
https://codereview.chromium.org/420443003/ So maybe just revert your changes in
this file and wait for mine to land.

[spang, 2014-07-24 18:35:44]

https://codereview.chromium.org/409163004/diff/60001/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/409163004/diff/60001/media/BUILD.gn#newcode528
media/BUILD.gn:528: inputs = [ platform_list_txt_file ]
On 2014/07/24 18:12:08, brettw wrote:
> This code is all messed up (beyond the error you're seeing here). I ran into
> this problem this morning and I think this patch should fix it properly:
> https://codereview.chromium.org/420443003/ So maybe just revert your changes
in
> this file and wait for mine to land.

Done.

[spang, 2014-07-24 18:35:55]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2014-07-24 18:38:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/spang@chromium.org/409163004/80001

[commit-bot: I haz the power, 2014-07-24 20:38:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-24 20:44:21]

Change committed as 285362