Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 409143002: [screen-orientation] Don't always unlock when fullscreen state is left. (Closed)

Created:
6 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@start_stop_listening
Project:
chromium
Visibility:
Public.

Description

[screen-orientation] Don't always unlock when fullscreen state is left. Sometimes fullscreen wasn't required in order to lock. In such case, fullscreen being left should have no consequence. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/browser/screen_orientation/screen_orientation_provider_android.cc View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mlamouri (slow - plz ping)
6 years, 5 months ago (2014-07-22 14:51:51 UTC) #1
Michael van Ouwerkerk
lgtm
6 years, 5 months ago (2014-07-22 15:09:13 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 5 months ago (2014-07-22 15:10:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/409143002/1
6 years, 5 months ago (2014-07-22 15:11:18 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:07:40 UTC) #5
Message was sent while issue was closed.
Change committed as 284743

Powered by Google App Engine
This is Rietveld 408576698