Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 409133006: The sandbox setup script now uses CHROMIUM_OUT_DIR when defined. (Closed)

Created:
6 years, 5 months ago by mustaq
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

The sandbox setup script now uses CHROMIUM_OUT_DIR when defined. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/update-linux-sandbox.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
mustaq
6 years, 5 months ago (2014-07-23 16:52:16 UTC) #1
Rick Byers
LGTM cc: jln who added this script in case he has any comments. Seems trivial ...
6 years, 5 months ago (2014-07-23 17:09:23 UTC) #2
jln (very slow on Chromium)
lgtm
6 years, 5 months ago (2014-07-23 19:12:09 UTC) #3
mustaq
The CQ bit was checked by mustaq@chromium.org
6 years, 5 months ago (2014-07-23 19:14:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mustaq@chromium.org/409133006/1
6 years, 5 months ago (2014-07-23 19:16:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 22:42:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 22:59:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/42344)
6 years, 5 months ago (2014-07-23 22:59:43 UTC) #8
mustaq
The CQ bit was checked by mustaq@chromium.org
6 years, 5 months ago (2014-07-24 14:43:18 UTC) #9
mustaq
The CQ bit was unchecked by mustaq@chromium.org
6 years, 5 months ago (2014-07-24 14:43:19 UTC) #10
mustaq
The CQ bit was checked by mustaq@chromium.org
6 years, 5 months ago (2014-07-24 14:44:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mustaq@chromium.org/409133006/1
6 years, 5 months ago (2014-07-24 14:45:48 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 16:37:23 UTC) #13
Message was sent while issue was closed. 
Change committed as 285296

Powered by Google App Engine
This is Rietveld 408576698