Issue 409123002: app_list ExtensionAppModelBuilder: Observe and handle changes to prefs::kHideWebStoreIcon

Issue 409123002: app_list ExtensionAppModelBuilder: Observe and handle changes to prefs::kHideWebStoreIcon (Closed)

Created:
6 years, 5 months ago by Marc Treib

Modified:
6 years, 4 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

app_list ExtensionAppModelBuilder: Observe and handle changes to prefs::kHideWebStoreIcon. The pref was already implicitly checked on initialization during PopulateApps (via extensions::ui_util::ShouldDisplayInAppLauncher). This CL adds handling of pref changes by re-checking ShouldDisplayInAppLauncher. It also extends an existing test to cover these cases. Handling of prefs::kHideWebStoreIcon was originally added in https://codereview.chromium.org/12038067 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285886

Patch Set 1 #

Patch Set 2 : typo #

Total comments: 2

Patch Set 3 : review comment #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -17 lines)			Patch
M	chrome/browser/ui/app_list/extension_app_model_builder.h	View		3 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_model_builder.cc	View	1 2	4 chunks	+37 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc	View	1 2	1 chunk	+16 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

xiyuan

Mostly good. https://codereview.chromium.org/409123002/diff/20001/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc File chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc (right): https://codereview.chromium.org/409123002/diff/20001/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc#newcode45 chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc:45: bool ModelContains(app_list::AppListModel* model, const std::string& id) { ...

6 years, 5 months ago (2014-07-23 16:26:55 UTC) #2

Marc Treib

https://codereview.chromium.org/409123002/diff/20001/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc File chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc (right): https://codereview.chromium.org/409123002/diff/20001/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc#newcode45 chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc:45: bool ModelContains(app_list::AppListModel* model, const std::string& id) { On 2014/07/23 ...

6 years, 5 months ago (2014-07-24 08:19:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/409123002/40001

6 years, 4 months ago (2014-07-28 07:56:20 UTC) #6

Message was sent while issue was closed.

Change committed as 285886

Expand Messages | Collapse Messages