Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 409113009: NaCl: Update revision in DEPS, r13506 -> r13511 (Closed)

Created:
6 years, 5 months ago by Derek Schuff
Modified:
6 years, 4 months ago
CC:
chromium-reviews, jvoung - send to chromium..., native-client-reviews_googlegroups.com, noelallen_use_chromium
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13506 -> r13511 This pulls in the following Native Client changes: r13507: (noelallen) Reapply patch which was reverted due to conflict. r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names. r13510: (dschuff) Disable flaky sandboxed translator tests on mac r13511: (dschuff) Update revision for PNaCl r13466->r13509 BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build (linux_rel_precise32,linux_arm_cross_compile omitted because they are currently broken) R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Derek Schuff
this one looks more green. git CL try (and CQ?) doesn't work yet because LKGR ...
6 years, 5 months ago (2014-07-23 06:09:18 UTC) #1
jvoung (off chromium)
lgtm
6 years, 5 months ago (2014-07-23 15:38:34 UTC) #2
Derek Schuff
The CQ bit was checked by dschuff@chromium.org
6 years, 5 months ago (2014-07-23 15:52:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/409113009/1
6 years, 5 months ago (2014-07-23 15:53:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 18:19:37 UTC) #5
Derek Schuff
6 years, 5 months ago (2014-07-23 18:32:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r284995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698