tools/perf/measurements/smoothness.py - Issue 409113006: Don't rely only on __del__ to cleanup PowerMetric when Smoothness.DidRunActions is not called.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness.py

Issue 409113006: Don't rely only on __del__ to cleanup PowerMetric when Smoothness.DidRunActions is not called. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/smoothness.py

diff --git a/tools/perf/measurements/smoothness.py b/tools/perf/measurements/smoothness.py

index d771917a7613051a1ee462a4f5ad7817e7a83df4..b90a56b540d3871ad21c066e9fcf2d712693fb91 100644

--- a/tools/perf/measurements/smoothness.py

+++ b/tools/perf/measurements/smoothness.py

@@ -35,5 +35,8 @@ class Smoothness(page_measurement.PageMeasurement):

self._power_metric.AddResults(tab, results)

self._smoothness_controller.AddResults(tab, results)

- def CleanUpAfterPage(self, _, tab):

- self._smoothness_controller.CleanUp(tab)

+ def CleanUpAfterPage(self, page, tab):

+ if self._power_metric:

+ self._power_metric.Stop(page, tab)

tonyg 2014/07/22 22:46:12 Doesn't this mean we'll run it twice in the common

chrishenry 2014/07/22 22:56:37 Yes, it's robust to that (_StopInternal is idempot

+ if self._smoothness_controller:

+ self._smoothness_controller.CleanUp(tab)

« no previous file with comments | « no previous file | tools/perf/measurements/smoothness_unittest.py » ('j') | no next file with comments »