Don't rely only on __del__ to cleanup PowerMetric when Smoothness.DidRunActions is not called.

Don't rely only on __del__ to cleanup PowerMetric when Smoothness.DidRunActions is not called.

Now, CleanUpAfterPage will also do the cleanup. (This is not a great
solution, but it will unblock the other patch without re-engineering
the whole resource cleanup mechanisms.)

In my other patch, the order of GC changes somehow (not sure yet why),
which caused SmoothnessUnitTest to fail since __del__ is not called
before the next test starts.

BUG=350841, 348271
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284868

[tonyg, 2014-07-22 22:46:13]

https://codereview.chromium.org/409113006/diff/1/tools/perf/measurements/smoo...
File tools/perf/measurements/smoothness.py (right):

https://codereview.chromium.org/409113006/diff/1/tools/perf/measurements/smoo...
tools/perf/measurements/smoothness.py:40: self._power_metric.Stop(page, tab)
Doesn't this mean we'll run it twice in the common case? Is the implementation
robust to that?

[chrishenry, 2014-07-22 22:56:37]

I cleaned up the unit test further, should be nicer now.

https://codereview.chromium.org/409113006/diff/1/tools/perf/measurements/smoo...
File tools/perf/measurements/smoothness.py (right):

https://codereview.chromium.org/409113006/diff/1/tools/perf/measurements/smoo...
tools/perf/measurements/smoothness.py:40: self._power_metric.Stop(page, tab)
On 2014/07/22 22:46:12, tonyg wrote:
> Doesn't this mean we'll run it twice in the common case? Is the implementation
> robust to that?

Yes, it's robust to that (_StopInternal is idempotent). FWIW, we _already_ run
this twice in the common case (once more in __del__), now we run it thrice. ;)

[nednguyen, 2014-07-22 23:01:47]

On 2014/07/22 22:56:37, chrishenry wrote:
> I cleaned up the unit test further, should be nicer now.
> 
>
https://codereview.chromium.org/409113006/diff/1/tools/perf/measurements/smoo...
> File tools/perf/measurements/smoothness.py (right):
> 
>
https://codereview.chromium.org/409113006/diff/1/tools/perf/measurements/smoo...
> tools/perf/measurements/smoothness.py:40: self._power_metric.Stop(page, tab)
> On 2014/07/22 22:46:12, tonyg wrote:
> > Doesn't this mean we'll run it twice in the common case? Is the
implementation
> > robust to that?
> 
> Yes, it's robust to that (_StopInternal is idempotent). FWIW, we _already_ run
> this twice in the common case (once more in __del__), now we run it thrice. ;)

We should unify the infrastructure for Start & Stop these profilers with
uber_tracing works. I will LGTM this for now to unblock Chris from doing his
changes.

[chrishenry, 2014-07-23 00:35:54]

The CQ bit was checked by chrishenry@google.com

[commit-bot: I haz the power, 2014-07-23 00:37:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/409113006/20001

[commit-bot: I haz the power, 2014-07-23 01:28:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-23 01:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 01:44:22]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[nednguyen, 2014-07-23 03:21:53]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-07-23 03:23:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishenry@google.com/409113006/20001

[commit-bot: I haz the power, 2014-07-23 06:43:34]

Change committed as 284868