Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 409113005: Added fastbuild config variable to isolate.gypi to let isolates test it. (Closed)

Created:
6 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Vadim Sh., csharp, bajones, Zhenyao Mo, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added fastbuild config variable to isolate.gypi to let isolates test it. Also added chrome_child.dll.pdb to telemetry_gpu_test isolate. This is in order to get better stack traces for debugging Issue 383963. BUG=385976, 383963 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284760

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M build/isolate.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/telemetry_gpu_test.isolate View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Russell (switch to Gerrit)
PTAL
6 years, 5 months ago (2014-07-22 19:43:53 UTC) #1
M-A Ruel
lgtm
6 years, 5 months ago (2014-07-22 19:45:16 UTC) #2
Ken Russell (switch to Gerrit)
I'm sending this through NOTRY=true because it's intended to get more debugging information for existing ...
6 years, 5 months ago (2014-07-22 19:47:03 UTC) #3
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 5 months ago (2014-07-22 19:47:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/409113005/1
6 years, 5 months ago (2014-07-22 19:49:08 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:51:36 UTC) #6
Message was sent while issue was closed.
Change committed as 284760

Powered by Google App Engine
This is Rietveld 408576698