Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 409073004: Rebase global-constructors-listing following r178747 (Closed)

Created:
6 years, 5 months ago by jsbell
Modified:
6 years, 5 months ago
Reviewers:
zino
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Rebase global-constructors-listing following r178747 Let's get the safety net back in place ASAP. Patches that modify the set of global constructors should include updated expectations for this test to indicate that the changes are intentional. BUG=388780 TBR=jinho.bang@samsung.com NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178775

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 5 months ago (2014-07-23 18:01:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/409073004/1
6 years, 5 months ago (2014-07-23 18:02:11 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 18:02:51 UTC) #3
Message was sent while issue was closed.
Change committed as 178775

Powered by Google App Engine
This is Rietveld 408576698