Issue 409073003: Make tracing based Timeline stop after reloading inspected page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409073003: Make tracing based Timeline stop after reloading inspected page (Closed)

Created:
6 years, 5 months ago by yurys

Modified:
6 years, 5 months ago

Reviewers:
caseq, alph, loislo

CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make tracing based Timeline stop after reloading inspected page This change fixes the following problem: 1. Run browser with remote debugging enabled (--remote-debugging-port=9222) 2. Open remote debugging front-end in the same browser (localhost:9222) 3. Inspect that front-end using built-in DevTools. 4. Go to Timeline and press Ctrl+R Result: Timeline recording starts automatically and never stops after reload. With this patch: It will stop recoding after reload. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284706

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/browser/devtools/devtools_tracing_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/browser/devtools/devtools_tracing_handler.cc	View		3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/409073003/1

6 years, 5 months ago (2014-07-22 14:51:41 UTC) #4

Message was sent while issue was closed.

Change committed as 284706

Expand Messages | Collapse Messages