Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: Tools/GardeningServer/ui/ct-builder-grid-tests.html

Issue 409063002: Simplify failing builder lists. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: make resultTypes private Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-builder-grid-tests.html
diff --git a/Tools/GardeningServer/ui/ct-builder-grid-tests.html b/Tools/GardeningServer/ui/ct-builder-grid-tests.html
index 4bb358e5ceb95fe1d00698fa19a1d9344c755259..59c72eca885ecc13f8616b7a4a3d0e61aa9a97cd 100644
--- a/Tools/GardeningServer/ui/ct-builder-grid-tests.html
+++ b/Tools/GardeningServer/ui/ct-builder-grid-tests.html
@@ -13,24 +13,13 @@ var kExampleFailures = [{
"testName": "plugins/gesture-events-scrolled.html",
"resultNodesByBuilder": {
"WebKit Win7 (dbg)": {
- "expected": "PASS",
- "is_unexpected": true,
"actual": "CRASH",
- "time": 0.9
},
"WebKit Mac10.6 (dbg)": {
- "expected": "PASS",
- "is_unexpected": true,
"actual": "CRASH",
- "has_stderr": true,
- "time": 1.8
},
"WebKit Mac10.7": {
- "expected": "PASS",
- "is_unexpected": true,
"actual": "TEXT",
- "has_stderr": true,
- "time": 3.2
}
},
"oldestFailingRevision": 177164,
@@ -39,17 +28,10 @@ var kExampleFailures = [{
"testName": "plugins/transformed-events.html",
"resultNodesByBuilder": {
"WebKit Win7 (dbg)": {
- "expected": "PASS",
- "is_unexpected": true,
"actual": "TEXT",
- "time": 0.6
},
"WebKit Mac10.7": {
- "expected": "PASS",
- "is_unexpected": true,
"actual": "CRASH",
- "has_stderr": true,
- "time": 3.2
},
},
"oldestFailingRevision": 177164,
@@ -70,30 +52,27 @@ var kExampleBuilderLatestRevisions = {
module("ct-builder-grid");
-asyncTest("basic", 11, function() {
+asyncTest("basic", 10, function() {
var grid = document.createElement('ct-builder-grid');
grid.failures = kExampleFailures;
- grid.builderLatestRevisions = kExampleBuilderLatestRevisions;
requestAnimationFrame(function() {
var rows = grid.shadowRoot.querySelectorAll('tbody tr');
- equal(rows.length, 3);
+ equal(rows.length, 2);
var row1 = grid.shadowRoot.querySelector('tbody td.CRASH').parentNode;
- equal(row1.children.length, 3);
- equal(row1.children[1].querySelectorAll('ct-builder').length, 1);
- equal(row1.children[1].querySelectorAll('ct-builder')[0].builderName, 'WebKit Mac10.7');
-
- equal(row1.children[2].querySelectorAll('ct-builder').length, 2);
- equal(row1.children[2].querySelectorAll('ct-builder')[0].builderName, 'WebKit Mac10.6 (dbg)');
- equal(row1.children[2].querySelectorAll('ct-builder')[1].builderName, 'WebKit Win7 (dbg)');
+ equal(row1.children.length, 2);
+ equal(row1.children[1].querySelectorAll('ct-builder').length, 3);
+ equal(row1.children[1].querySelectorAll('ct-builder')[0].builder, 'WebKit Mac10.6 (dbg)');
+ equal(row1.children[1].querySelectorAll('ct-builder')[1].builder, 'WebKit Mac10.7');
+ equal(row1.children[1].querySelectorAll('ct-builder')[2].builder, 'WebKit Win7 (dbg)');
var row2 = grid.shadowRoot.querySelector('tbody td.TEXT').parentNode;
- equal(row2.children.length, 3);
- equal(row2.children[1].querySelectorAll('ct-builder').length, 1);
- equal(row2.children[2].querySelectorAll('ct-builder').length, 1);
+ equal(row2.children.length, 2);
+ equal(row2.children[1].querySelectorAll('ct-builder').length, 2);
+ equal(row2.children[1].querySelectorAll('ct-builder')[0].builder, 'WebKit Mac10.7');
+ equal(row2.children[1].querySelectorAll('ct-builder')[1].builder, 'WebKit Win7 (dbg)');
- notEqual(rows[2].children[0].className.indexOf('BUILDING'), -1);
start();
});
});

Powered by Google App Engine
This is Rietveld 408576698