Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: tools/telemetry/telemetry/value/merge_values.py

Issue 409023002: Add SkipValue to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ned's comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/skip.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/merge_values.py
diff --git a/tools/telemetry/telemetry/value/merge_values.py b/tools/telemetry/telemetry/value/merge_values.py
index 89d187824e19fd7e5bb7a45083cae1f6e45f3e0d..6d24686db3ea061d314364de2e81ae9fe619ddf9 100644
--- a/tools/telemetry/telemetry/value/merge_values.py
+++ b/tools/telemetry/telemetry/value/merge_values.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
from telemetry.value import failure
+from telemetry.value import skip
def MergeLikeValuesFromSamePage(all_values):
"""Merges values that measure the same thing on the same page.
@@ -112,9 +113,12 @@ def GroupStably(all_values, key_func):
merge_groups_in_creation_order = []
for value in all_values:
# TODO(chrishenry): This is temporary. When we figure out the
- # right summarization strategy for page runs with failures, we
+ # right summarization strategy for page runs with failures/skips, we
# should use that instead.
- if isinstance(value, failure.FailureValue):
+ should_skip_value = (isinstance(value, failure.FailureValue) or
+ isinstance(value, skip.SkipValue))
+
+ if should_skip_value:
continue
key = key_func(value)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/value/skip.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698