chrome/android/java/res/values/dimens.xml - Issue 409003002: Redesign GUI of Website Setting Popup Dialog

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 409003002: Redesign GUI of Website Setting Popup Dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change java jni function names Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/website_settings.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6	6

7 <resources>	7 <resources>

8 <!-- Certificate Viewer Dimensions -->	8 <!-- Certificate Viewer Dimensions -->

9 <dimen name="certificate_viewer_padding">20dp</dimen>	9 <dimen name="certificate_viewer_padding">24dp</dimen>
	aurimas (slooooooooow) 2014/07/22 22:05:36 Rename to certificate_viewer_padding_wide since yo Rename to certificate_viewer_padding_wide since you are adding the second one. Ian Wen 2014/07/23 00:05:41 Not renamed as thin is used in XML. Show quoted text On 2014/07/22 22:05:36, aurimas wrote: > Rename to certificate_viewer_padding_wide since you are adding the second one. Not renamed as thin is used in XML. aurimas (slooooooooow) 2014/07/23 00:13:31 I do not understand? I am suggesting to rename cer Show quoted text On 2014/07/23 00:05:41, Ian Wen wrote: > On 2014/07/22 22:05:36, aurimas wrote: > > Rename to certificate_viewer_padding_wide since you are adding the second one. > > Not renamed as thin is used in XML. I do not understand? I am suggesting to rename certificate_viewer_padding to certificate_viewer_padding_wide and keep certificate_viewer_padding_thin as it is. Ian Wen 2014/07/23 00:38:16 Done. Show quoted text On 2014/07/23 00:13:31, aurimas wrote: > On 2014/07/23 00:05:41, Ian Wen wrote: > > On 2014/07/22 22:05:36, aurimas wrote: > > > Rename to certificate_viewer_padding_wide since you are adding the second > one. > > > > Not renamed as thin is used in XML. > > I do not understand? I am suggesting to rename certificate_viewer_padding to > certificate_viewer_padding_wide and keep certificate_viewer_padding_thin as it > is. Done.
	10 <dimen name="certificate_viewer_padding_thin">16dp</dimen>

10	11

11 <!-- Accessibility tab switcher -->	12 <!-- Accessibility tab switcher -->

12 <dimen name="accessibility_tab_height">65dp</dimen>	13 <dimen name="accessibility_tab_height">65dp</dimen>

13	14

14 <!-- TabSwitcher - The minimum distance from the edge to commit a side swap. -->	15 <!-- TabSwitcher - The minimum distance from the edge to commit a side swap. -->

15 <dimen name="swipe_commit_distance">120dp</dimen>	16 <dimen name="swipe_commit_distance">120dp</dimen>

16	17

17 <!-- Custom Menu dimensions -->	18 <!-- Custom Menu dimensions -->

18 <dimen name="menu_width">260dp</dimen>	19 <dimen name="menu_width">260dp</dimen>

19 <dimen name="menu_vertical_offset">0dp</dimen>	20 <dimen name="menu_vertical_offset">0dp</dimen>

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 <dimen name="app_banner_title_margin_top">0dp</dimen>	66 <dimen name="app_banner_title_margin_top">0dp</dimen>

66 <dimen name="app_banner_title_margin_bottom">8dp</dimen>	67 <dimen name="app_banner_title_margin_bottom">8dp</dimen>

67	68

68 <dimen name="app_banner_logo_height">24dp</dimen>	69 <dimen name="app_banner_logo_height">24dp</dimen>

69 <dimen name="app_banner_logo_margin_top">4dp</dimen>	70 <dimen name="app_banner_logo_margin_top">4dp</dimen>

70 <dimen name="app_banner_logo_margin_bottom">0dp</dimen>	71 <dimen name="app_banner_logo_margin_bottom">0dp</dimen>

71 <dimen name="app_banner_logo_margin_end">8dp</dimen>	72 <dimen name="app_banner_logo_margin_end">8dp</dimen>

72	73

73 <dimen name="app_banner_star_height">16dp</dimen>	74 <dimen name="app_banner_star_height">16dp</dimen>

74 </resources>	75 </resources>

OLD	NEW