Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408923002: Add auto purging for SkPicture-related Ganesh resources (esp. layers) (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add auto purging for SkPicture-related Ganesh resources (esp. layers) This is intended to lower the bookkeeping burden for the Layer Caching feature. Cached layers are now automatically purged when a picture is deleted. Committed: https://skia.googlesource.com/skia/+/d771f6bc273457bc7aa95938ac326dfbbf876e1a

Patch Set 1 #

Patch Set 2 : Move MessageBus Inbox from GrContext to GrLayerCache #

Total comments: 2

Patch Set 3 : Remove stray #include #

Patch Set 4 : Make picture deletion listener ref counted #

Patch Set 5 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -64 lines) Patch
M include/core/SkCanvas.h View 1 chunk +0 lines, -6 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkPicture.h View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPicture.cpp View 1 2 3 2 chunks +21 lines, -1 line 0 comments Download
M src/gpu/GrLayerCache.h View 1 2 3 3 chunks +19 lines, -3 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 4 chunks +32 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 2 3 4 chunks +26 lines, -8 lines 0 comments Download
M tools/PictureBenchmark.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
6 years, 5 months ago (2014-07-22 14:05:33 UTC) #1
bsalomon
https://codereview.chromium.org/408923002/diff/20001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/408923002/diff/20001/include/core/SkPicture.h#newcode193 include/core/SkPicture.h:193: struct DeletionListener { Should this be ref cnt'ed? would ...
6 years, 5 months ago (2014-07-22 14:13:48 UTC) #2
robertphillips
https://codereview.chromium.org/408923002/diff/20001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.chromium.org/408923002/diff/20001/include/core/SkPicture.h#newcode193 include/core/SkPicture.h:193: struct DeletionListener { On 2014/07/22 14:13:48, bsalomon wrote: > ...
6 years, 5 months ago (2014-07-22 16:35:47 UTC) #3
bsalomon
lgtm
6 years, 5 months ago (2014-07-22 17:04:05 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-22 17:05:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/408923002/80001
6 years, 5 months ago (2014-07-22 17:05:53 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 17:18:12 UTC) #7
Message was sent while issue was closed. 
Change committed as d771f6bc273457bc7aa95938ac326dfbbf876e1a

Powered by Google App Engine
This is Rietveld 408576698