Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 408913003: Only allow path as target for mpath (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
pdr., fs, kouhei (in TOK)
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Only allow path as target for mpath Be more strict and only allow a path as href target. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/svg/SVGMPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
PTAL
6 years, 5 months ago (2014-07-22 15:42:00 UTC) #1
kouhei (in TOK)
non-owner lgtm
6 years, 5 months ago (2014-07-22 15:42:58 UTC) #2
fs
This appears to be consistent with the pathElement() accessor, so LGTM.
6 years, 5 months ago (2014-07-22 18:03:23 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-24 07:09:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/408913003/1
6 years, 5 months ago (2014-07-24 07:10:27 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 08:19:42 UTC) #6
Message was sent while issue was closed.
Change committed as 178824

Powered by Google App Engine
This is Rietveld 408576698