Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: tools/perf/measurements/skpicture_printer_unittest.py

Issue 408913002: Wire FailureValue in PageTestResults (try 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/skpicture_printer_unittest.py
diff --git a/tools/perf/measurements/skpicture_printer_unittest.py b/tools/perf/measurements/skpicture_printer_unittest.py
index e7871db626036d8a1721857fb50798aa483a2def..7c35992bcb282bd18fb4fd93576d1bbb4519d306 100644
--- a/tools/perf/measurements/skpicture_printer_unittest.py
+++ b/tools/perf/measurements/skpicture_printer_unittest.py
@@ -9,6 +9,7 @@ from measurements import skpicture_printer
from telemetry.page import page_measurement_unittest_base
from telemetry.unittest import options_for_unittests
from telemetry.unittest import test
+from telemetry.value import failure
class SkpicturePrinterUnitTest(
@@ -28,7 +29,8 @@ class SkpicturePrinterUnitTest(
# Picture printing is not supported on all platforms.
if results.failures:
- assert 'not supported' in results.failures[0][1]
+ assert 'not supported' in failure.GetStringFromExcInfo(
nednguyen 2014/07/23 16:34:49 A better alternative could be str(results.failures
chrishenry 2014/07/23 17:48:24 Done. results.failures[0].exc_info[1].message is t
+ results.failures[0].exc_info)
return
saved_picture_count = results.FindAllPageSpecificValuesNamed(
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | tools/telemetry/telemetry/results/page_test_results.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698