tools/perf/measurements/skpicture_printer_unittest.py - Issue 408913002: Wire FailureValue in PageTestResults (try 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/skpicture_printer_unittest.py

Issue 408913002: Wire FailureValue in PageTestResults (try 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comment. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/skpicture_printer_unittest.py

diff --git a/tools/perf/measurements/skpicture_printer_unittest.py b/tools/perf/measurements/skpicture_printer_unittest.py

index e7871db626036d8a1721857fb50798aa483a2def..6df3752f329779a7c6dba2a9ee1cb88359b2f295 100644

--- a/tools/perf/measurements/skpicture_printer_unittest.py

+++ b/tools/perf/measurements/skpicture_printer_unittest.py

@@ -28,7 +28,7 @@ class SkpicturePrinterUnitTest(

# Picture printing is not supported on all platforms.

if results.failures:

- assert 'not supported' in results.failures[0][1]

+ assert 'not supported' in results.failures[0].exc_info[1].message

return

saved_picture_count = results.FindAllPageSpecificValuesNamed(

« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »