Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 408913002: Wire FailureValue in PageTestResults (try 2). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 from telemetry.results import base_test_results_unittest 5 from telemetry.results import base_test_results_unittest
6 6
7 from telemetry.page import page_set 7 from telemetry.page import page_set
8 from telemetry.results import page_test_results 8 from telemetry.results import page_test_results
9 from telemetry.value import failure
9 10
10 class NonPrintingPageTestResults( 11 class NonPrintingPageTestResults(
11 page_test_results.PageTestResults): 12 page_test_results.PageTestResults):
12 def __init__(self): 13 def __init__(self):
13 super(NonPrintingPageTestResults, self).__init__() 14 super(NonPrintingPageTestResults, self).__init__()
14 15
15 def _PrintPerfResult(self, *args): 16 def _PrintPerfResult(self, *args):
16 pass 17 pass
17 18
18 class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest): 19 class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
19 def setUp(self): 20 def setUp(self):
20 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__)) 21 self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
21 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/") 22 self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
22 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/") 23 self.page_set.AddPageWithDefaultRunNavigate("http://www.baz.com/")
23 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/") 24 self.page_set.AddPageWithDefaultRunNavigate("http://www.foo.com/")
24 25
25 @property 26 @property
26 def pages(self): 27 def pages(self):
27 return self.page_set.pages 28 return self.page_set.pages
28 29
29 def test_failures(self): 30 def test_failures(self):
30 results = NonPrintingPageTestResults() 31 results = NonPrintingPageTestResults()
31 results.AddFailure(self.pages[0], self.CreateException()) 32 results.AddValue(
33 failure.FailureValue(self.pages[0], self.CreateException()))
32 results.AddSuccess(self.pages[1]) 34 results.AddSuccess(self.pages[1])
33 self.assertEquals(results.pages_that_had_failures, 35 self.assertEquals(results.pages_that_had_failures, set([self.pages[0]]))
34 set([self.pages[0]]))
35 self.assertEquals(results.successes, [self.pages[1]]) 36 self.assertEquals(results.successes, [self.pages[1]])
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698