Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 408873003: Add chrome_proxy tests to Android tester. (Closed)

Created:
6 years, 5 months ago by bolian
Modified:
6 years, 5 months ago
Reviewers:
navabi1, tonyg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add chrome_proxy tests to Android tester. This is modeled after https://codereview.chromium.org/235573010. chrome_proxy tests were originally part of telemetry pref tests and split out with https://codereview.chromium.org/397483002/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M build/android/buildbot/bb_device_steps.py View 3 chunks +17 lines, -3 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
bolian
Hello Armand and Tony, This CL adds chrome_proxy tests Android target which were part of ...
6 years, 5 months ago (2014-07-21 21:13:39 UTC) #1
tonyg
Just to verify. To these hit the live network?
6 years, 5 months ago (2014-07-22 03:08:48 UTC) #2
bolian
On 2014/07/22 03:08:48, tonyg wrote: > Just to verify. To these hit the live network? ...
6 years, 5 months ago (2014-07-22 07:35:20 UTC) #3
navabi
On 2014/07/22 07:35:20, bolian wrote: > On 2014/07/22 03:08:48, tonyg wrote: > > Just to ...
6 years, 5 months ago (2014-07-22 10:18:37 UTC) #4
bolian
On 2014/07/22 10:18:37, navabi wrote: > On 2014/07/22 07:35:20, bolian wrote: > > On 2014/07/22 ...
6 years, 5 months ago (2014-07-22 16:51:02 UTC) #5
navabi1
lgtm but let's wait for tonyg too. we always want to be careful adding things ...
6 years, 5 months ago (2014-07-23 11:46:00 UTC) #6
bolian
On 2014/07/23 11:46:00, navabi1 wrote: > lgtm but let's wait for tonyg too. we always ...
6 years, 5 months ago (2014-07-23 18:20:47 UTC) #7
tonyg
lgtm
6 years, 5 months ago (2014-07-23 19:08:31 UTC) #8
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 5 months ago (2014-07-23 22:30:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/408873003/1
6 years, 5 months ago (2014-07-23 22:34:00 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 11:44:30 UTC) #11
Message was sent while issue was closed.
Change committed as 285197

Powered by Google App Engine
This is Rietveld 408576698