Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 408853004: Remove nss_util.h dependency from FakeCryptohomeClient. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove nss_util.h dependency from FakeCryptohomeClient. Also removes the unused tpm_token_name_ member from TPMTokenLoader. BUG=NONE R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chromeos/dbus/fake_cryptohome_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/tpm_token_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/tpm_token_loader.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
ptal The important thing is the removed dependency on that constant in nss_util.h, because I ...
6 years, 5 months ago (2014-07-21 13:18:50 UTC) #1
stevenjb
lgtm
6 years, 5 months ago (2014-07-21 16:43:38 UTC) #2
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-21 16:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/408853004/1
6 years, 5 months ago (2014-07-21 16:53:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 20:02:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 21:15:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/32780)
6 years, 5 months ago (2014-07-21 21:15:46 UTC) #7
pneubeck (no reviews)
6 years, 5 months ago (2014-07-22 07:18:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r284641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698