Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 408843004: Convert more tests into text-based-repaint tests (Closed)

Created:
6 years, 5 months ago by Xianzhu
Modified:
6 years, 5 months ago
Reviewers:
chrishtr, enne (OOO)
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Convert more tests into text-based-repaint tests - less code - to be able to use features of text-based-repaint.js Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178600

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove LayoutTests/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -514 lines) Patch
M LayoutTests/compositing/layer-creation/compositing-reason-removed.html View 1 chunk +3 lines, -18 lines 0 comments Download
M LayoutTests/compositing/overflow/scrolling-without-painting.html View 1 chunk +5 lines, -19 lines 0 comments Download
M LayoutTests/compositing/overflow/updating-scrolling-content.html View 3 chunks +10 lines, -13 lines 0 comments Download
M LayoutTests/compositing/repaint/invalidations-on-composited-layers.html View 1 chunk +5 lines, -33 lines 0 comments Download
M LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download
M LayoutTests/compositing/repaint/repaint-into-ancestor-after-layout.html View 2 chunks +6 lines, -16 lines 0 comments Download
M LayoutTests/compositing/squashing/invalidations-with-large-negative-margin.html View 1 chunk +5 lines, -26 lines 0 comments Download
M LayoutTests/compositing/squashing/repaint-squashed-layer-in-rect.html View 1 chunk +6 lines, -27 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-partial-repaint-inside-squashed-layer.html View 1 chunk +4 lines, -16 lines 0 comments Download
M LayoutTests/compositing/squashing/squash-partial-repaint-inside-squashed-layer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/repaint/fixed-element-repaint-after-compositing-update.html View 2 chunks +2 lines, -29 lines 0 comments Download
D LayoutTests/platform/android/compositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/platform/android/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/platform/linux/compositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/fixed-element-repaint-after-compositing-update-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/linux/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
M LayoutTests/platform/mac/fast/repaint/fixed-element-repaint-after-compositing-update-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/win-xp/compositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/fixed-element-repaint-after-compositing-update-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/fixed-element-repaint-after-compositing-update-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt View 1 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Xianzhu
https://codereview.chromium.org/408843004/diff/1/LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt File LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt (left): https://codereview.chromium.org/408843004/diff/1/LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt#oldcode12 LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt:12: ], This was extra repaints caused by the output ...
6 years, 5 months ago (2014-07-21 18:33:37 UTC) #1
chrishtr
https://codereview.chromium.org/408843004/diff/1/LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt File LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt (right): https://codereview.chromium.org/408843004/diff/1/LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt#newcode10 LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt:10: "position": [8, 8], What about this change? Why does ...
6 years, 5 months ago (2014-07-21 19:05:34 UTC) #2
Xianzhu
https://codereview.chromium.org/408843004/diff/1/LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt File LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt (right): https://codereview.chromium.org/408843004/diff/1/LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt#newcode10 LayoutTests/compositing/repaint/invalidations-on-composited-layers-expected.txt:10: "position": [8, 8], On 2014/07/21 19:05:34, chrishtr wrote: > ...
6 years, 5 months ago (2014-07-21 19:15:25 UTC) #3
Xianzhu
To fix failures on trybot, I should also remove the baselines of virtual tests of ...
6 years, 5 months ago (2014-07-21 19:17:21 UTC) #4
chrishtr
lgtm
6 years, 5 months ago (2014-07-21 19:18:52 UTC) #5
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 5 months ago (2014-07-21 21:50:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/408843004/20001
6 years, 5 months ago (2014-07-21 21:50:34 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-21 22:55:28 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 23:23:19 UTC) #9
Message was sent while issue was closed. 
Change committed as 178600

Powered by Google App Engine
This is Rietveld 408576698