Issue 408843003: Set the state of a swept page after being done with sweeping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408843003: Set the state of a swept page after being done with sweeping. (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)

Modified:
6 years, 4 months ago

Reviewers:
titzer, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Set the state of a swept page after being done with sweeping. BUG= R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22514

Patch Set 2 : #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
	M	src/mark-compact.cc	View	1	5 chunks	+22 lines, -14 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

titzer

lgtm https://codereview.chromium.org/408843003/diff/20001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/408843003/diff/20001/src/mark-compact.cc#newcode4088 src/mark-compact.cc:4088: if (mode == MarkCompactCollector::SWEEP_IN_PARALLEL) { How about we ...

6 years, 5 months ago (2014-07-21 19:19:49 UTC) #3

Hannes Payer (out of office)

https://codereview.chromium.org/408843003/diff/20001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/408843003/diff/20001/src/mark-compact.cc#newcode4088 src/mark-compact.cc:4088: if (mode == MarkCompactCollector::SWEEP_IN_PARALLEL) { On 2014/07/21 19:19:48, titzer ...

6 years, 5 months ago (2014-07-21 19:22:13 UTC) #4

Hannes Payer (out of office)

6 years, 5 months ago (2014-07-21 19:24:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r22514 (presubmit successful).

Expand Messages | Collapse Messages

Issue 408843003: Set the state of a swept page after being done with sweeping. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages